[PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses
    Jason Molenda via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Dec 19 09:16:40 PST 2022
    
    
  
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
I think we both agree that OptionArgParser::ToAddress needs to fix the address, but I don't have an opinion about whether we should also do it in GetBreakableLoadAddress.  I'm fine if you think we should do it here too, for other codepaths that can try to set a breakpoint on a signed function pointer address.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136938/new/
https://reviews.llvm.org/D136938
    
    
More information about the llvm-commits
mailing list