[PATCH] D140087: [X86] Replace (31/63 -/^ X) with (NOT X) and ignore (32/64 ^ X) when computing shift count

Mon Dec 19 09:07:55 PST 2022

goldstein.w.n marked 3 inline comments as done.
goldstein.w.n added inline comments.

================
Comment at: llvm/test/CodeGen/X86/not-shift.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=-bmi,-tbm,-bmi2 < %s | FileCheck %s --check-prefixes=X86-NOBMI2
+; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=+bmi,-tbm,-bmi2 < %s | FileCheck %s --check-prefixes=X86-NOBMI2
----------------
pengfei wrote:
> What's `tbm` used for. Seems it doesn't affect the result?
Removed in V3. Was unneeded. Had copied the command from another test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140087/new/

https://reviews.llvm.org/D140087