[PATCH] D140088: Add LLVM type support for fp8

Mon Dec 19 09:00:01 PST 2022

arsenm added a comment.

In D140088#4005153 <https://reviews.llvm.org/D140088#4005153>, @arsenm wrote:

> In D140088#4005142 <https://reviews.llvm.org/D140088#4005142>, @kushanam wrote:
>
>> In D140088#4005134 <https://reviews.llvm.org/D140088#4005134>, @arsenm wrote:
>>
>>> Tests still missing
>>
>> Hi @arsenm, I looked at the existing tests and got an assumption that the existing way to test those, is to have the codegen pipeline supporting the datatype in the "Target" level. That is something I am working on for the follow up patch and thought then I could add the tests. If you could give me a pointer to the existing tests that I might have missed, I would add them. Thank you in advance!
>
> All of the IR changes are testable without codegen support. Needs some tests in test/Assembler, test/Bitcode, test/Verifier, and some constant folding tests in test/Transforms/InstSimplify. See 8c24f33158d81d5f4b0c5d27c2f07396f0f1484b <https://reviews.llvm.org/rG8c24f33158d81d5f4b0c5d27c2f07396f0f1484b> which added bfloat (although this includes far fewer tests than I would have liked to see. For example it's missing the all important bitcode compatibility tests)

I think I covered all the bases for testing an IR change in D139902 <https://reviews.llvm.org/D139902>. This is a bit broader as it's a type

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140088/new/

https://reviews.llvm.org/D140088