[PATCH] D133943: [Utils] Match function return type and other attributes on the definition in update_cc_test_checks

Mon Dec 19 07:42:49 PST 2022

asb added a comment.

In D133943#4004616 <https://reviews.llvm.org/D133943#4004616>, @arichardson wrote:

> Seeing as there are around 300 tests inside llvm/ that use --function-signature and 200+ in clang/, maybe this needs a "only for new tests" workaround such as D140212 <https://reviews.llvm.org/D140212>.
> The other option would be to bulk-update all affected tests once this lands, but I'm not sure how the maintainers of the affected tests feel about this.

The current formulation of this patch only changes behavior for update_llc_test_checks.py to only affects the tests listed above in clang/test. I'm fairly neutral about exactly how such a change would be rolled out.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133943/new/

https://reviews.llvm.org/D133943