[PATCH] D140305: [GlobalISel][Legalizer] add minScalarIf action

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 07:13:57 PST 2022


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:966
+        },
+        changeElementTo(typeIdx(TypeIdx), Ty));
+  }
----------------
Should only use changeElementTo if this handles vectors, which it doesn't. Use changeTo or make minScalarOrEltIf


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140305/new/

https://reviews.llvm.org/D140305



More information about the llvm-commits mailing list