[PATCH] D139420: [GlobalISel][Legalizer] add minScalarIf action

[Ties Stuij via Phabricator via llvm-commits]

stuij marked an inline comment as done.
stuij added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:954
+  /// Conditionally limit the minimum size of the scalar.
+  LegalizeRuleSet &minScalarIf(LegalityPredicate Predicate, unsigned TypeIdx,
+                               const LLT Ty) {
----------------
paquette wrote:
> Can you add a test for this function in `llvm/unittests/CodeGen/GlobalISel/LegalizerInfoTest.cpp`?
> 
> Then maybe split this into two patches:
> 
> Patch 1: Add `minScalarIf`
> Patch 2: Add the new lowering
thanks, I made a separate patch for `minScalarIf`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139420/new/

https://reviews.llvm.org/D139420