[PATCH] D140291: [llvm-objcopy] Use getNumberOfSymbols() instead of getRawNumberOfSymbols()

[Daan De Meyer via Phabricator via llvm-commits]

DaanDeMeyer added a comment.

Here's the offending file: F25733195: linuxaa64.efi.stub <https://reviews.llvm.org/F25733195>

If we look at the PE header, we can see that the symbol table is 0x0000 while the symbol count is 1. This executable is systemd's EFI stub built on aarch64 using gnu-efi (build file can be found here: https://github.com/systemd/systemd/blob/main/src/boot/efi/meson.build).

  ➜  llvm-project git:(coff-symbols) xxd linuxaa64.efi.stub | head
  00000000: 4d5a 0000 0000 0000 0000 0000 0000 0000  MZ..............
  00000010: 0000 0000 0000 0000 0000 0000 0000 0000  ................
  00000020: 0000 0000 0000 0000 0000 0000 0000 0000  ................
  00000030: 0000 0000 0000 0000 0000 0000 4000 0000  ............ at ...
  00000040: 5045 0000 64aa 0200 0000 0000 0000 0000  PE..d...........
  00000050: 0100 0000 a000 0602 0b02 0214 00c0 0000  ................
  00000060: 001e 0000 0000 0000 0010 0000 0010 0000  ................
  00000070: 0000 0000 0000 0000 0010 0000 0002 0000  ................
  00000080: 0000 0000 0000 0000 0000 0000 0000 0000  ................
  00000090: 00ee 0000 0010 0000 0000 0000 0a00 0000  ................

I'll address the rest of the issues later today. Thanks for taking the time to review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140291/new/

https://reviews.llvm.org/D140291