[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I have a question why the option is needed.

    if (IBTSeal) {
      return F.hasAddressTaken();
    }
    // if !IBTSeal, fall into default case.
    LLVM_FALLTHROUGH;
  // Address taken or externally linked functions may be reachable.
  default:
    return (F.hasAddressTaken() || !F.hasLocalLinkage());

`F.hasAddressTaken() || !F.hasLocalLinkage()` can be changed to `F.hasAddressTaken() || (F.hasHiddenVisibility() && !F.hasLocalLinkage())`

Why can't the kernel use `-fvisibility=hidden`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116070/new/

https://reviews.llvm.org/D116070