[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D139644#4004024 <https://reviews.llvm.org/D139644#4004024>, @thakis wrote:

> In D139644#4003708 <https://reviews.llvm.org/D139644#4003708>, @thakis wrote:
>
>> Also, I'm getting `Could not load library '...InlineAdvisorPlugin.so': ...InlineAdvisorPlugin.so: undefined symbol: _ZN4llvm27PluginInlineAdvisorAnalysis17HasBeenRegisteredE` when running the test. That's probably because the plugin includes the file that declares that file-level static but then doesn't have a definition of it in the linkage unit (?)
>
> This was due to me not linking AnalysisTests with -rdynamic.
>
> Things work now over here.
>
> The "this is unusual" comment remains :)

Can we help @IBricchi with a recommendation as to how to author a test - for example, perhaps having a subdirectory for the test plugin?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644