[PATCH] D140273: [MC] Use `MCRegister` instead of `unsigned` in `MCTargetAsmParser`

Sun Dec 18 12:10:43 PST 2022

MaskRay added a comment.

In D140273#4003890 <https://reviews.llvm.org/D140273#4003890>, @barannikov88 wrote:

> In D140273#4003886 <https://reviews.llvm.org/D140273#4003886>, @MaskRay wrote:
>
>> Perhaps fix that in a separate commit?
>
> Fine by me.

OK, I fixed it in 68c73bf7b236d4e6b9ac549c39a5fe3d701dfeee <https://reviews.llvm.org/rG68c73bf7b236d4e6b9ac549c39a5fe3d701dfeee>. Thanks for reporting the issue.

> In D140273#4003882 <https://reviews.llvm.org/D140273#4003882>, @MaskRay wrote:
>
>> lib/Target/*/AsmParser and tablegen generated files still have many `unsigned RegNo` or `unsigned RegNum`, but this is a step forward...
>
> I hoped no one would remember it. Those are less annoying though, so maybe next time.
> Can I ask you to merge this patch? I still don't have permission.
>
> "Sergei Barannikov <barannikov88 at gmail.com>".

`ninja -C /tmp/Rel check-llvm && llvm-push` in one minute...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140273/new/

https://reviews.llvm.org/D140273