[PATCH] D139407: [llvm-objdump][AArch64] Fix ADRP target label calculation

Sun Dec 18 10:26:52 PST 2022

MaskRay added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/ELF/AArch64/pcrel-address.yaml:19
     Content: '02010090'
-  - Name:    .data
-    Type:    SHT_PROGBITS
----------------
krisb wrote:
> krisb wrote:
> > MaskRay wrote:
> > > Having the label is an interesting case. Consider adding another case without `.data`?
> > Could you please give more details why the case with `.data` is an interesting one?
> > If we keep the `.data` in the example, objdump will not be able to find target label for `0x220000` address since it'll reject `.text`, considering only `.data` one, which doesn't contain any symbols.
> > I'm okay to add another test w/o data, just want to understand what intent was/is under the `.data` section, if you have some time to give the details.
> > 
> @MaskRay 
> I added another case where `adrp`'s label points inside `.text` keeping original one that points inside `.data`.
> But since there are no symbols in `.data` we do not have target address label calculated for the address from the original case.
> Hope, I got you right. 
Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139407/new/

https://reviews.llvm.org/D139407