[PATCH] D139913: [runtimes] Only depend on builtins for same target
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 18 08:56:59 PST 2022
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/runtimes/CMakeLists.txt:423
+ if(builtins_dep)
+ set(name_builtins_dep "${builtins_dep}-${name}")
+ endif()
----------------
Super minor nit: I think that `builtins_dep_name` would be more consistent with other variables used in this file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139913/new/
https://reviews.llvm.org/D139913
More information about the llvm-commits
mailing list