[PATCH] D140263: [NFC] Vastly simplifies TypeSize

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 06:47:43 PST 2022


gchatelet added a comment.

Thx @barannikov88 for the comments. This patch is mostly to better understand what purpose `TypeSize` serves.
I'm trying to add a set of useful basic types D128052 <https://reviews.llvm.org/D128052> and `ElementCount` / `TypeSize` will probably be tied to one of these at some point.



================
Comment at: llvm/include/llvm/Support/TypeSize.h:168
 
-  /// Add \p RHS to the value at the univariate dimension.
-  LeafTy getWithIncrement(ScalarTy RHS) const {
-    return static_cast<LeafTy>(
-        UnivariateLinearPolyBase(Value + RHS, UnivariateDim));
+  /// Add \p Rhs to the value at the univariate dimension.
+  LeafTy getWithIncrement(ScalarTy Rhs) const {
----------------
barannikov88 wrote:
> univariate dimension --> fixed quantity?
> 
Reworded it MinValue since this is what it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140263/new/

https://reviews.llvm.org/D140263



More information about the llvm-commits mailing list