[PATCH] D136043: [CodeGen] Replace CCValAssign::Loc with a discriminated union (NFCI)
Sergei Barannikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 17 14:01:31 PST 2022
barannikov88 marked 3 inline comments as done.
barannikov88 added a comment.
In D136043#4003403 <https://reviews.llvm.org/D136043#4003403>, @tschuett wrote:
> Either you have to keep `LockKind` in-sync with the variants or you have to keep the variants in the functions in-sync. Either is fine by me.
I see now, thanks. That is actually a good point that I didn't think of.
I removed the enum and updated methods to use types as you suggested in inline comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136043/new/
https://reviews.llvm.org/D136043
More information about the llvm-commits
mailing list