[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/unittests/Analysis/CMakeLists.txt:60
+if (LLVM_HAVE_TFLITE)
+  LIST(APPEND EXTRA_TESTS ${MLGO_TESTS})
+else()
----------------
note: I got rid of the `EXTRA_TESTS` since having `ANALYSIS_TEST_SOURCES` removes the need for an extra list: e can just append to the latter.


================
Comment at: llvm/unittests/Analysis/CMakeLists.txt:99
+  add_dependencies(AnalysisTests InlineAdvisorPlugin)
+
+  # The plugin depends on some of the output files of llvm-tblgen, so make sure
----------------
Ack.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644