[PATCH] D133192: [LICM] Allow load-only scalar promotion in the presence of aliasing loads

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 17 01:19:35 PST 2022


djtodoro added a comment.

Great!



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:182
                                 function_ref<void(Instruction *)> Fn);
-static SmallVector<SmallSetVector<Value *, 8>, 0>
+static SmallVector<std::pair<SmallSetVector<Value *, 8>, bool>, 0>
 collectPromotionCandidates(MemorySSA *MSSA, AliasAnalysis *AA, Loop *L);
----------------
Nit: Can we make a type alias for this, it is too long now. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133192/new/

https://reviews.llvm.org/D133192



More information about the llvm-commits mailing list