[PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

Fri Dec 16 21:58:24 PST 2022

jasonmolenda added a comment.

Hi David, thanks for the ping sorry for not replying earlier to this.  I looked at this a little bit today but want to look at how I solved the same issue a while ago (but never upstreamed, which is my bad, I need to clean those up).  (I did solved this in OptionArgParser::ToAddress and I haven't looked at this enough to argue for mine over your approach -- but mine gets you any address expression command like `source lookup -a` and `image lookup -a` etc.  I'll look at this more closely this weekend and follow up though.

(I got distracted way too much when I tried to make a repo test case, and my function pointer variable was called `f` and it would never work.  I looked at it with Jim and we were both confused mightily, until we noticed that OptionArgParser::ToAddress throws things through a "see if it can be parsed as base16 even without a prefix" so you can't use a variable name that consists of [a-f][0-9a-f]* lol.  Jim or I are definitely going to be removing that little bit of too-cleverness.)

At first I was wondering if the ABI should save the ArchSpec it is created with so it can call the Architecture's GetBreakableLoadAddress instead of requiring all the callers to call both of these, but I see from the ppc64 description of what that method does, it would not be applicable to most code addresses, only function entry, and only when we were calling into this function I think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136938/new/

https://reviews.llvm.org/D136938