[PATCH] D138792: [AArch64] Improve TargetParser API

Fri Dec 16 19:59:06 PST 2022

MaskRay added a comment.

In D138792#3970376 <https://reviews.llvm.org/D138792#3970376>, @tmatheson wrote:

> @MaskRay I reverted that commit because it broke important functionality (comparison by address) to fix an issue in an unsupported C++ version, it wasn't reviewed, and it was not clear from the commit message what it was fixing. I explained this in a comment on the original commit but forgot to add it to the message for the revert, sorry.

That happened! Don't worry.

> @saugustine I have reverted the patch while I address the issues that you and others have raised. In future if would be helpful if you provided some information about how to reproduce the error. However it looks like this is also related to C++20, and I would like to understand what the policy is there. As far as I am aware this is an untested configuration. If you are building with C++20 and any otherwise-good patches that break your build must be reverted, then there should be a buildbot covering that configuration. Without a buildbot, I think the onus should be on you to suggesting a fix, or at least give enough details to reproduce the problem and allow time for a fix. Apologies if I have misunderstood something.

Thanks! You can set `-DCMAKE_CXX_STANDARD=20` to test C++20. https://raw.githubusercontent.com/chromium/chromium/main/tools/clang/scripts/update.py has a prebuilt Clang which can be used as `CMAKE_{C,CXX}_COMPILER`.
A build bot is in plan https://discourse.llvm.org/t/adding-a-c-20-buildbot/67156

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792