[PATCH] D140256: [BOLT] Check no-LBR samples in mayHaveProfileData

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 18:36:13 PST 2022


Amir created this revision.
Amir added a reviewer: bolt.
Herald added a reviewer: rafauler.
Herald added subscribers: treapster, ayermolo.
Herald added a reviewer: maksfb.
Herald added a project: All.
Amir requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

No-LBR mode wasn't tested and slipped when mayHaveProfileData was added for 
Lite mode. This enables processing of profiles collected without LBR and
converted with `perf2bolt -nl` option.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140256

Files:
  bolt/lib/Profile/DataReader.cpp


Index: bolt/lib/Profile/DataReader.cpp
===================================================================
--- bolt/lib/Profile/DataReader.cpp
+++ bolt/lib/Profile/DataReader.cpp
@@ -1331,7 +1331,8 @@
   if (getBranchData(Function) || getMemData(Function))
     return true;
 
-  if (getBranchDataForNames(Function.getNames()) ||
+  if (getFuncSampleData(Function.getNames()) ||
+      getBranchDataForNames(Function.getNames()) ||
       getMemDataForNames(Function.getNames()))
     return true;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140256.483703.patch
Type: text/x-patch
Size: 500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221217/8140c427/attachment.bin>


More information about the llvm-commits mailing list