[PATCH] D140245: [PowerPC] Don't crash when disassembling invalid immediate

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 15:01:30 PST 2022


nemanjai added a comment.

In D140245#4002642 <https://reviews.llvm.org/D140245#4002642>, @barannikov88 wrote:

> AFAIK values >12 are all invalid, not only those that are >15. This instruction and the one which inserts elements need custom decoder for their operands. Other changes are unnecessary.
> But let's see what PPC guys say.

Thank you for your comment. However, I must clarify. Values larger than 12 produce undefined results, but they are not invalid. The instruction `xxinsertw vs1, vs2, 14` is not an illegal instruction - although it does produce undefined results.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140245/new/

https://reviews.llvm.org/D140245



More information about the llvm-commits mailing list