[PATCH] D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS.

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 14:19:53 PST 2022


int3 added a comment.

> Making them warnings seems like a good compromise to me, since people can then use -fatal_warnings if they want to turn this into errors and we don't need a new flag.

My understanding is that some third-party/system libraries have these unsatisfied dependencies baked in, so it's not something that's always fixable in the build. We shouldn't require people to turn off `-fatal_warnings` in their builds to support third-party unfixable stuff.

I'm leaning toward Vy's option #3 (extend existing flag, no new flags), though I think #1 is good too (would make it easier for people to drop in LLD into their builds)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140225/new/

https://reviews.llvm.org/D140225



More information about the llvm-commits mailing list