[PATCH] D139418: [AArch64] GlobalIsel codegen for gpr CTZ

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

I had two minor comments, but after you fix those, I think this is good to go.



================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:674
+      .legalIf([=](const LegalityQuery &Query) {
+                 if (HasCSSC && typeInSet(0, {s32, s64})(Query))
+                   return true;
----------------
Might as well just return here.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:679
+      .customIf([=](const LegalityQuery &Query) {
+                 if (!HasCSSC && typeInSet(0, {s32, s64})(Query))
+                   return true;
----------------
Might as well just return here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139418/new/

https://reviews.llvm.org/D139418