[PATCH] D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS.

[Keith Smiley via Phabricator via llvm-commits]

keith added a comment.

I wonder if at this point we should just implement LD64's behavior with an off-by-default flag to be more strict? Specifically they ignore these failures and collect the missing ones and only print about them in the case the link fails



================
Comment at: lld/MachO/Options.td:99
 def ignore_auto_link_option : Separate<["--"], "ignore-auto-link-option">,
-    Group<grp_lld>;
+    Group<grp_lld>; 
 def ignore_auto_link_option_eq : Joined<["--"], "ignore-auto-link-option=">,
----------------
nit: accidental whitespace


================
Comment at: lld/MachO/Options.td:104
     Group<grp_lld>;
+def ignore_auto_link_errors : Flag<["-"], "ignore_auto_link_errors">,
+    HelpText<"Ignore framework or library not found errors if they are loaded via LC_LINKER_OPTIONS">,
----------------
for these options we've been using dashes instead of underscores


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140225/new/

https://reviews.llvm.org/D140225