[PATCH] D140233: [lld-macho][test][nfc] Update stabs.s to use GMT time zone instead of UTC

Pengxuan Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 10:49:46 PST 2022


pzheng created this revision.
pzheng added reviewers: int3, keith, thakis, haowei.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
pzheng requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is to work around a singularity container issue we ran into recently. The
container fails to honor the time zone setting (TZ=UTC) when executing the touch
command. Replacing UTC with GMT worked correctly in the container. This change
does not change (at least not intentionally) the function of the test in any way
since GMT and UTC should be equivalent AFAIK. Please refer to the discussions in
D139980 <https://reviews.llvm.org/D139980> for more background information.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140233

Files:
  lld/test/MachO/stabs.s


Index: lld/test/MachO/stabs.s
===================================================================
--- lld/test/MachO/stabs.s
+++ lld/test/MachO/stabs.s
@@ -5,8 +5,8 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/foo.s -o %t/foo.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/no-debug.s -o %t/no-debug.o
 ## Set modtimes of the files for deterministic test output.
-# RUN: env TZ=UTC touch -t "197001010000.16" %t/test.o
-# RUN: env TZ=UTC touch -t "197001010000.32" %t/foo.o
+# RUN: env TZ=GMT touch -t "197001010000.16" %t/test.o
+# RUN: env TZ=GMT touch -t "197001010000.32" %t/foo.o
 # RUN: llvm-ar rcsU %t/foo.a %t/foo.o
 
 # RUN: ZERO_AR_DATE=0 %lld -lSystem %t/test.o %t/foo.o %t/no-debug.o -o %t/test


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140233.483598.patch
Type: text/x-patch
Size: 741 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221216/c931fb94/attachment.bin>


More information about the llvm-commits mailing list