[PATCH] D140229: [SeparateConstOffsetFromGEP] Remove TypeSize error when collecting constant indices.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 16 10:27:41 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp:1015
+ // Constant offsets of scalable types are not really constant.
+ if (DL->getTypeAllocSize(GTI.getIndexedType()).isScalable())
+ continue;
----------------
arsenm wrote:
> Is there not a way to directly check isScalable on the type without going through getTypeAllocSize?
Looks like we're missing isScalableVectorTy, it should be there
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140229/new/
https://reviews.llvm.org/D140229
More information about the llvm-commits
mailing list