[PATCH] D135202: [IR] Add a target extension type to LLVM.

[Joshua Cranmer via Phabricator via llvm-commits]

jcranmer-intel added a comment.

In D135202#3996159 <https://reviews.llvm.org/D135202#3996159>, @aeubanks wrote:

> the comments and patch description are inconsistent about "opaque" vs "target extension", cleaning this up would be good for avoiding confusion in the future

I updated the git commit message locally, but it seems that Arcanist wasn't taking the changes into account here.



================
Comment at: llvm/test/Assembler/target-type-properties.ll:13
+}
+
+;--- global-var.ll
----------------
arsenm wrote:
> Is empty string valid?
Yes, it should be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135202/new/

https://reviews.llvm.org/D135202