[PATCH] D140106: [AggressiveInstCombine] Fix invalid TypeSize conversion when combining loads.
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 16 06:51:11 PST 2022
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:776
TargetTransformInfo &TTI, AliasAnalysis &AA) {
LoadOps LOps;
if (!foldLoadsRecursive(&I, LOps, DL, AA) || !LOps.FoundRoot)
----------------
Perhaps move the check to here? This is the "entry point" of the optimization, and none of it was designed for vectors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140106/new/
https://reviews.llvm.org/D140106
More information about the llvm-commits
mailing list