[PATCH] D139858: [SCEVExpander] Increase "cheap" expansion budget for loop invariants, but not loop exit values

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D139858#4001178 <https://reviews.llvm.org/D139858#4001178>, @nikic wrote:

> I'd be more comfortable with this if it adjusted just the unroll limit, where a higher cost is probably justifiable relative to the cost of everything else.



> This change affects a lot of transforms, and from the test diffs alone, some of them look non-profitable to me, e.g. most of the changes in llvm/test/Transforms/IndVarSimplify/post-inc-range.ll due to questionable LFTR transforms.

I'm not sure i understand. This kind of change we see in post-inc-range.ll, is exactly why i bothered to unbreak the original `isHighCostExpansion` originally in the first place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139858/new/

https://reviews.llvm.org/D139858