[PATCH] D140212: [update_test_checks] Default to --function-signature for new tests

[Alexander Richardson via Phabricator via llvm-commits]

arichardson created this revision.
arichardson added reviewers: nikic, lebedev.ri, jdoerfert, spatel, sebastian-ne.
Herald added a project: All.
arichardson requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As was recently brought up in D139006 <https://reviews.llvm.org/D139006>, not using --function-signature by
default can cause tests to fail unexpectedly due to not matching "define"
in the function declaration. The referenced review tried to fix this but
was ultimately reverted due to the test churn that it causes.

This is an alternative approach, suggested by @nikic in D139006 <https://reviews.llvm.org/D139006> that
defaults to --function-signature for new tests but keeps existing ones
unchanged. The implementation is somewhat ugly, using magic constants
for the --function-signature flag default values, but I can't see a way of
avoiding this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140212

Files:
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/argument_name_reuse.ll
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/basic.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/basic.ll.funcsig.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/check_attrs.ll
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/check_attrs.ll.funcattrs.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/custom-tool.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/function_name.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/no-funcsig-for-existing-note.ll
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/no-funcsig-for-existing-note.ll.expected-with-flag
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/no-funcsig-for-existing-note.ll.expected-with-negative-flag
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/no-funcsig-for-existing-note.ll.expected-with-unrelated-flag
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.initially_disabled.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/prefix-never-matches.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.plain.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.scrub.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/sometimes_deleted_function.ll.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll
  llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.globals.expected
  llvm/test/tools/UpdateTestChecks/update_test_checks/basic.test
  llvm/test/tools/UpdateTestChecks/update_test_checks/no-funcsig-for-existing-note.test
  llvm/utils/UpdateTestChecks/common.py
  llvm/utils/update_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140212.483512.patch
Type: text/x-patch
Size: 28167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221216/f824c98f/attachment.bin>