[PATCH] D140088: Add LLVM type support for fp8

[Stella Laurenzo via Phabricator via llvm-commits]

stellaraccident added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:1819
     default: llvm_unreachable("Unknown FP format");
+    case MVT::fp8e4m3:
+      return APFloat::Float8E4M3FN();
----------------
I think we agreed that this should be f8e4m3 (no "p") to match the others. We would follow the convention that we established in MLIR, as that was what was discussed.

https://github.com/llvm/llvm-project/blob/main/mlir/lib/AsmParser/TokenKinds.def#L96


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140088/new/

https://reviews.llvm.org/D140088