[PATCH] D137837: [Support] Move Target/CPU Printing out of CommandLine

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 05:26:50 PST 2022


lebedev.ri added a comment.

In D137837#4000960 <https://reviews.llvm.org/D137837#4000960>, @lenary wrote:

> In D137837#3976344 <https://reviews.llvm.org/D137837#3976344>, @MaskRay wrote:
>
>> I think this patch can drop `cl::AddExtraVersionPrinter(sys::printDefaultTargetAndDetectedCPU);` from most tools. Only add them case by case when there is consensus there is a significant value.
>>
>> Many tools get the default target and CPU information by the generic code and it seems that most don't care about the information from the non-flagship tools.
>
> I have left the info in `llc` and `opt`.

Please, like i asked already, don't break llvm-exegesis and llvm-mca.

> All other tools no longer have this info, but I hope it is clear how to re-add it if people want that in future.
>
> Note: LLD does not print this, and clang prints the info a different way.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137837/new/

https://reviews.llvm.org/D137837



More information about the llvm-commits mailing list