[PATCH] D140108: [AMDGPU][AsmParser][NFC] Refine parsing cache policy modifiers.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 03:07:42 PST 2022


dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:6047
+    bool Disabling;
+    unsigned P = parseCPolId(getId(), Mnemo, Disabling);
+    if (!P)
----------------
kosarev wrote:
> dp wrote:
> > Maybe `CPolId` would be better than `P`.
> What if just `CPol` then? So it doesn't look like we parse an id into another id.
Good point. CPol is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140108/new/

https://reviews.llvm.org/D140108



More information about the llvm-commits mailing list