[PATCH] D139133: [SPIR-V] Support memory(...) function attributes

Thu Dec 15 17:24:00 PST 2022

arsenm added a comment.

In D139133#3997323 <https://reviews.llvm.org/D139133#3997323>, @mpaszkowski wrote:

> In D139133#3997203 <https://reviews.llvm.org/D139133#3997203>, @nikic wrote:
>
>> In D139133#3996834 <https://reviews.llvm.org/D139133#3996834>, @mpaszkowski wrote:
>>
>>> @arsenm I have removed the checks for `ReadNone` and also for `ReadOnly`. Both are replaced with the new `memory(...)` attributes in functions. I will keep tests for the legacy attributes because we have compilers feeding old LLVM IR into the SPIR-V backend.
>>
>> The old attributes are converted into the new one during IR parsing, so that probably doesn't really test anything useful?
>
> Are there any plans to remove the conversion in the long term? If there are/would be then the LIT tests would give us useful information why some runtime tests are failing without the need for debugging.

The tests you have here would break if the parsing stops recognizing it. There's no plus to keeping the legacy check here

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139133/new/

https://reviews.llvm.org/D139133