[PATCH] D139970: [llvm][CallBrPrepare] use SSAUpdater to use intrinsic value

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

Thanks for the review!



================
Comment at: llvm/lib/CodeGen/CallBrPrepare.cpp:181
+    for (Use &U : CBR->uses()) {
+      PrintDebugDomInfo(DT, U, LandingPad, /*IsDefaultDest*/ false);
+      PrintDebugDomInfo(DT, U, DefaultDest, /*IsDefaultDest*/ true);
----------------
nickdesaulniers wrote:
> aeubanks wrote:
> > I'd just `ifndef NDEBUG` around these two lines and remove the empty `PrintDebugDomInfo` implementation
> Slight disagree, but could be convinced otherwise. Do you feel strongly about this?
To expand on why I disagree; I'm optimizing for readability of the import part of the code (the part that's doing meaningful work). I'd prefer to hide the ugly ifdefs around the optional debug routine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139970/new/

https://reviews.llvm.org/D139970