[PATCH] D139414: [RISCV] Emit .variant_cc directives for vector function calls.
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 15 15:03:43 PST 2022
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
There's missing context in the review description which is important. Please add something along the lines of the following.
The currently ratified calling convention in psABI does not support passing vector arguments or return values in registers. LLVM implements a non-standard calling convention for vector arguments and returns. psABI requires that such non-standard calling conventions be tagged w/ .variant_cc.
With that additional context, LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139414/new/
https://reviews.llvm.org/D139414
More information about the llvm-commits
mailing list