[PATCH] D140166: [IR] return nullptr in Instruction::getInsertionPointAfterDef for CallBrInst

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

This looks fine, apart from the coro-debug.ll bit, that I'm not familiar with.



================
Comment at: llvm/lib/IR/Instruction.cpp:141
   } else if (auto *CB = dyn_cast<CallBrInst>(this)) {
-    InsertBB = CB->getDefaultDest();
-    InsertPt = InsertBB->getFirstInsertionPt();
+    return nullptr;
   } else {
----------------
Maybe comment on why? (Def is available in multiple successors, there's no single dominating insertion point.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140166/new/

https://reviews.llvm.org/D140166