[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D139644#3999423 <https://reviews.llvm.org/D139644#3999423>, @IBricchi wrote:

> We cleaned up the cmake file so that it now compiles all the unit test under unified target and only setting the test plugin implementation as an optional source, and does the opposite for the test plugin target

OK, but that doesn't explain why it'd want to do the opposite for the test plugin target.

Also, my suggestion was to do that change - i.e. the change that makes conditional compilation of certain files (except for the to-be-introduced plugin unit test) in a separate patch, which would have to land first. This is so that the concerns are separated: one thing is about having a different build behavior on certain platforms. The other is adding the new unit test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644