[llvm] fedcdd2 - Revert "[NFC][DebugInfo] Autogenerate check lines in assignment-tracking/sroa/*"

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 14:05:52 PST 2022


Thanks.

On Fri, Dec 16, 2022 at 12:26 AM Robinson, Paul <paul.robinson at sony.com> wrote:
>
> > > > As per post-commit feedback, DebugInfo owners are not receptive of the
> > > > idea of having a single source of truth instead of relying on everyone
> > > > to know how to update these tests manually.
> > >
> > > This commit message is inappropriate and certainly bends the
> > > Code of Conduct. Please don't do that again.
> > Hm, i think i'm missing some wording lessons here.
> > It was not meant to be hostile, i just explained the status of things?
> > How was this supposed to be worded?
>
> It (incorrectly) implies a certain motive to the feedback I was providing,
Huh, interesting, I'm guessing that "motive" here is used in a negative sense.
That was not the meaning, i thought, the message was conveying.

>   and that's what I find inappropriate. The actual status of things is:
>   As per post-commit feedback, at the moment DebugInfo owners have
>   asked not to use the existing automated scripts to update the tests.
>
> Pure and simple. My state of mind is not to the point here.  Comments on
> what other people are thinking/feeling don't belong in commit messages.
>
> --paulr
Roman


More information about the llvm-commits mailing list