[PATCH] D140161: [SelectionDAG] Give all the target specific subclasses of SelectionDAGISel their own pass ID.

Thu Dec 15 13:59:00 PST 2022

nickdesaulniers added a comment.

In D140161#3999447 <https://reviews.llvm.org/D140161#3999447>, @arsenm wrote:

> In D140161#3999437 <https://reviews.llvm.org/D140161#3999437>, @nickdesaulniers wrote:
>
>> In D140161#3999433 <https://reviews.llvm.org/D140161#3999433>, @arsenm wrote:
>>
>>> Not allowing -stop-before/-stop-after the actual isel pass is probably a feature, not a bug. We don't run the verifier between that and finalizeisel. You can see verifier failing MIR at that point which would confuse
>>
>> Without `-stop-after`, how are folks expected to test SelectionDAG in isolation?
>
> You kind of don't. That's one of the major issues with it. After finalizeisel is the first point where you're consistently guaranteed verifiable mir

So why isn't `-stop-after=finalizeisel` working "not a bug?" (Perhaps I should have s/SelectionDAG/SelectionDAGISel/ above)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140161/new/

https://reviews.llvm.org/D140161