[PATCH] D140161: [SelectionDAG] Give all the target specific subclasses of SelectionDAGISel their own pass ID.

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 13:49:49 PST 2022


nickdesaulniers added a comment.

In D140161#3999433 <https://reviews.llvm.org/D140161#3999433>, @arsenm wrote:

> Not allowing -stop-before/-stop-after the actual isel pass is probably a feature, not a bug. We don't run the verifier between that and finalizeisel. You can see verifier failing MIR at that point which would confuse

Without `-stop-after`, how are folks expected to test SelectionDAG in isolation?

(`-stop-before` is the other side of the same coin as `-stop-after` for whatever pass comes before finalize-isel. It's asymmetric to support one without the other, but if I can only have one, that's good enough to do my job).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140161/new/

https://reviews.llvm.org/D140161



More information about the llvm-commits mailing list