[llvm] a33b40d - [NFC][DebugInfo] Autogenerate check lines in assignment-tracking/sroa/*

Robinson, Paul via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 12:37:53 PST 2022


> So it is nowhere near "Let's be generous and call it one-third",
> but "almost exactly half" of all existing `.ll` tests.
> Obviously, there are non-.ll tests, and obviously
> they are going to skew the stats in favor of your argument :)

Okay, let's be generous and call it half.
Half still isn't "pretty much all."

> If i was interested in throwing away tests, i would have simply
> unintentionally
> manually regressed the test coverage when trying to manually update them,
> and you would indeed be none the wiser. Should have i done just that?

Well, instead, you unintentionally regressed the test coverage
when using the automated script, which is really not better, is it?

> And please, i hope, by "your patch" you mean "any patch by anyone for
> which
> there happens to be DebugInfo test coverage"?

And who makes the mistake of using the automated scripts on a test
that does not already use them.
Yes, that was an improper characterization on my part, sorry!
--paulr



More information about the llvm-commits mailing list