[llvm] a33b40d - [NFC][DebugInfo] Autogenerate check lines in assignment-tracking/sroa/*

Robinson, Paul via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 10:47:24 PST 2022


> I don't disagree that the UTC results are ugly,
> but i very strongly believe that not using them
> is hostile to those who didn't write the original test,
> because such test are inherently fragile and hard to update,
> and modifying hand-crafted tests is a massive time sink
> not the least because it is not always obvious
> //how// they need to be updated. I remember having to
> manually write irgen tests for UBSan checks,
> and that memory does not bring me joy.
> 
> Would you prefer for me to XFAIL the debuginfo tests that are
> being affected by patches, and leave them for someone
> from debuginfo to update?

I am concerned that blindly converting to scripted checks
is going to lose more coverage than the one example that I
happened to notice by chance here. What validation do we 
have that the script is doing reasonable and correct things?
I see that you modified the script; did anyone with
debug-info expertise review that change?

Please do not XFAIL any debug-info tests without filing
an issue first, and if you could cite the issue in a comment 
by the XFAIL, that would be very helpful.

--paulr



More information about the llvm-commits mailing list