[PATCH] D140108: [AMDGPU][AsmParser][NFC] Refine parsing cache policy modifiers.
Dmitry Preobrazhensky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 15 10:44:06 PST 2022
dp accepted this revision.
dp added a comment.
Very nice refactoring!
================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:6047
+ bool Disabling;
+ unsigned P = parseCPolId(getId(), Mnemo, Disabling);
+ if (!P)
----------------
Maybe `CPolId` would be better than `P`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140108/new/
https://reviews.llvm.org/D140108
More information about the llvm-commits
mailing list