[PATCH] D140063: [AutoFDO] Use getHeadSamplesEstimate instead of getTotalSamples to compute profile callsite staleness

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 10:42:40 PST 2022


wlei added a comment.

In D140063#3998253 <https://reviews.llvm.org/D140063#3998253>, @wenlei wrote:

> I thought the idea is to compute the % of samples being dropped due to mismatch? in this case, all samples from callsite will be dropped, so I actually don't see a problem with using getTotalSamples. Yes you can argue that they can be merged with base profile, but then that argument applies to getHeadSamplesEstimate too?

Or since it's arguable, needed more discussion/experiments, I can make a separate patch for that, make this to fix the obvious issues first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140063/new/

https://reviews.llvm.org/D140063



More information about the llvm-commits mailing list