[PATCH] D137360: [Linker] Remove nocallback attribute while linking

[Nikita Popov via Phabricator via llvm-commits]

nikic added a reviewer: tejohnson.
nikic added a comment.

I'm fine with this in terms of semantics. Probably someone familiar with IR linking should also take a look at this to check that this is a reasonable place to do the adjustment.



================
Comment at: llvm/lib/Linker/LinkModules.cpp:383
+  // Drop nocallback attribute while linking because it is treated as a hint on
+  // the module level.
+  if (auto *F = dyn_cast<Function>(&GV))
----------------
I wouldn't use the term "hint" here. Maybe something like this:

> Drop nocallback attribute while linking, because the function might call an imported function, in which case it now calls back into the module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137360/new/

https://reviews.llvm.org/D137360