[PATCH] D140111: [lld][wasm] Split __wasm_apply_data_relocs when it exceeds the function size limit

[Illia Malachyn via Phabricator via llvm-commits]

k1nder10 added a comment.

It's my first time pushing the changes to LLVM.
Should I add some tests for this? If so, where could I find examples of them?



================
Comment at: lld/wasm/Driver.cpp:767
+
+    WasmSym::applyDataRelocsTail = symtab->addSyntheticFunction(
+        "__wasm_apply_data_relocs_tail",
----------------
I tried to move the creation of this function to Writer.cpp 1349 under 'else' statement, so that we don't have any changes in out .wasm files
unless we exceed the function size limit. However, I got some strange runtime errors. 

So, for now, we will have this function created even If we don't hit the limit (it just will be empty). Is it okay?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140111/new/

https://reviews.llvm.org/D140111