[llvm] 07343dc - Fix failing test in presence of exceptions D140098

Guillaume Chatelet via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 07:34:29 PST 2022


Author: Guillaume Chatelet
Date: 2022-12-15T15:34:04Z
New Revision: 07343dc0b6a29e23a93bc16fa8d3fa9c584851c1

URL: https://github.com/llvm/llvm-project/commit/07343dc0b6a29e23a93bc16fa8d3fa9c584851c1
DIFF: https://github.com/llvm/llvm-project/commit/07343dc0b6a29e23a93bc16fa8d3fa9c584851c1.diff

LOG: Fix failing test in presence of exceptions D140098

There is no point in testing this behavior since this is std::optional's semantic.

Added: 
    

Modified: 
    llvm/unittests/Support/AlignmentTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Support/AlignmentTest.cpp b/llvm/unittests/Support/AlignmentTest.cpp
index 07854dd32b8b..01ac02f49bef 100644
--- a/llvm/unittests/Support/AlignmentTest.cpp
+++ b/llvm/unittests/Support/AlignmentTest.cpp
@@ -234,10 +234,6 @@ std::vector<uint64_t> getValidAlignmentsForDeathTest() {
 
 std::vector<uint64_t> getNonPowerOfTwo() { return {3, 10, 15}; }
 
-TEST(AlignmentDeathTest, CantConvertUnsetMaybe) {
-  EXPECT_DEATH((MaybeAlign(0).value()), ".*");
-}
-
 TEST(AlignmentDeathTest, InvalidCTors) {
   EXPECT_DEATH((Align(0)), "Value must not be 0");
   for (uint64_t Value : getNonPowerOfTwo()) {


        


More information about the llvm-commits mailing list