[PATCH] D140098: [NFC] Use std::optional over llvm::Optional to implement MaybeAlign

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 05:58:00 PST 2022


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Support/Alignment.h:132
+  constexpr MaybeAlign(std::nullopt_t None) : UP(None) {}
+  constexpr MaybeAlign(Align Value) : UP(Value) {}
+  MaybeAlign(uint64_t Value) {
----------------
`explicit`


================
Comment at: llvm/lib/Support/OptimizedStructLayout.cpp:14
 #include "llvm/Support/OptimizedStructLayout.h"
+#include "llvm/ADT/Optional.h"
 
----------------
Layering I guess ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140098/new/

https://reviews.llvm.org/D140098



More information about the llvm-commits mailing list