[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 00:57:51 PST 2022


MaskRay added a comment.

Thanks for doing this!



================
Comment at: clang/lib/Driver/ToolChain.cpp:553
 
+  // armeb (big endian) is left out here on purpose so that we don't try to use
+  // little endian libraries in that case.
----------------
The comments can be combined. First state what this block does, then state that armeb is left out for a reason.

An example may be more descriptive than some words. Give an example of `getTriple()` and Arch values?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140011/new/

https://reviews.llvm.org/D140011



More information about the llvm-commits mailing list