[PATCH] D139133: [SPIR-V] Support memory(...) function attributes

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 00:27:14 PST 2022


nikic added a comment.

In D139133#3996834 <https://reviews.llvm.org/D139133#3996834>, @mpaszkowski wrote:

> @arsenm I have removed the checks for `ReadNone` and also for `ReadOnly`. Both are replaced with the new `memory(...)` attributes in functions. I will keep tests for the legacy attributes because we have compilers feeding old LLVM IR into the SPIR-V backend.

The old attributes are converted into the new one during IR parsing, so that probably doesn't really test anything useful?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139133/new/

https://reviews.llvm.org/D139133



More information about the llvm-commits mailing list